Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ember-try config #480

Merged
merged 3 commits into from
Jul 28, 2017
Merged

Fix ember-try config #480

merged 3 commits into from
Jul 28, 2017

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Jul 28, 2017

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Updated ember-try config

@quincyle
Copy link
Contributor

quincyle commented Jul 28, 2017 •
edited by dafortin
Loading

Approved

Approved with PullApprove

@EWhite613
Copy link
Contributor

EWhite613 commented Jul 28, 2017 •
edited
Loading

Problem is this line in the 2.8 test https://github.com/ciena-frost/ember-frost-core/blob/master/ember-cli-build.js#L27

Need to change it to programmatically bower_components location(if there's no ember-source
and import from there. Since currently, it's getting it from ember-source (even if ember-source doesn't exist)

@EWhite613
Copy link
Contributor

Same goes for ciena-frost/ember-frost-bunsen#460

@EWhite613 EWhite613 mentioned this pull request Jul 28, 2017
Merged
4 tasks
@EWhite613
Copy link
Contributor

EWhite613 commented Jul 28, 2017 •
edited by dafortin
Loading

Approved

Approved with PullApprove

@juwara0
Copy link
Contributor Author

juwara0 commented Jul 28, 2017

NOTE: We modified the ember-try config to use Ember 2.8 instead of Ember LTS 2.8 due to a difference in behavior when running frost-link in these two versions: #481

@juwara0
Copy link
Contributor Author

juwara0 commented Jul 28, 2017 •
edited by dafortin
Loading

👍

Approved with PullApprove

@juwara0 juwara0 merged commit 5047511 into ciena-frost:master Jul 28, 2017
@juwara0 juwara0 deleted the fixEmberTry branch July 28, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@quincyle quincyle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juwara0 @quincyle @EWhite613