Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address dependency management issues #491

Closed
63 tasks done
notmessenger opened this issue Nov 27, 2017 · 1 comment · Fixed by #505
Closed
63 tasks done

Address dependency management issues #491

notmessenger opened this issue Nov 27, 2017 · 1 comment · Fixed by #505
Labels

Comments

@notmessenger
Copy link
Contributor

notmessenger commented Nov 27, 2017

ciena-frost/ember-frost-demo-components#28 MUST be resolved before this issue can be addressed. Some of the individual tasks may be able to be worked on before the completion of the dependent issue. If doing so indicate which tasks have been completed by checking them off in the list below, as well as adding a comment to this issue indicating the name of the branch you have pushed to this repo so that work can completed once the dependent task has been addressed.

  • Tasks that have the text "(verified)" after them are ones that have either already been tested or are known to work. This does not mean that you should not still be cautious but you likely don't have to do as much research as you might initially be inclinded to.
  • None of the tasks make a determination of whether a dependency should be a dependency or devDependency UNLESS otherwise stated. Even then it is prudent to confirm this indicator.
  • All dependencies should float to ^ unless the directions in the tasks indicate otherwise. The following entries are known items that should REMAIN pinned:
    • ember-prism
    • ember-try

NPM

  • change ember-cli-babel to ^5.1.7 (verified)
  • determine whether ember-try can be removed.
    Quincy added to address a specific problem in 2.12.3 PR
    Update to [email protected] #460
  • upgrade ember-truth-helpers to ^1.3.0 (verified)
  • determine whether ember-browserify is needed. if so ^1.2.0 is latest
  • determine whether ember-simple-uuid is needed or can be removed or refactored. change to ^0.1.4 (version is verified)
  • upgrade ivy-codemirror to ^2.1.0 (verified)
  • upgrade ember-lodash-shim to ^2.0.7 (verified)
  • upgrade ember-ajax to ^2.5.6 (verified)
  • npm uninstall ember-frost-test and ember install ember-frost-test (verified)
    • ember-cli-chai will be updated to 0.4.3 so may encounter issues
    • ember-cli-mocha will be updated to 0.14.4 so may encounter issues
    • ember-sinon will be updated to ^0.7.0 so may encounter issues
    • ember-test-utils will be updated to ^7.02 so will encounter issues
  • remove eslint from (verified)
  • remove eslint-config-frost-standard (verified)
  • remove sass-lint (verified)
  • remove ember-moment
  • install ember-cli-moment-shim as dependency
    • add to NOTES.md that is a dependency so can be used by consumer
  • pin ember-cli-code-coverage to 0.3.12
  • verify ember-cli-code-coverage is tied into "npm run test" script
  • verify "tests/config/coverage.js" and not "config/coverage.js"
  • pin ember-computed-decorators to 0.3.0 (is an upgrade)
  • upgrade ember-cli-sass to pinned 7.1.1 (verified)
  • update ember-hook to 1.4.2
  • determine whether ember-hook needs to be a dependency
  • pin ember-elsewhere to 1.0.1 (verified)
  • pin ember-concurrency to 0.7.19 (verified)
  • update ember-sortable to ^1.10.0
  • should be able to remove ember-getowner-polyfill (as was only needed prior to Ember 2.3 - https://github.com/rwjblue/ember-getowner-polyfill)
    • if have to keep consider updating to ^2.2.0
  • update ember-cli-showdown to ^2.11.0 (verified)
  • pin ember-get-config to 0.2.2 and make a dependency
  • update or install ember-cli-frost-blueprints to ^5.0.0 (or whatever the latest release is) as devDependency
  • remove from blueprints and make dependency
    • ember-frost-date-picker
    • ember-frost-fields
    • ember-frost-table
  • remove from devDependency and make dependency
    • ember-frost-demo-components
    • ember-frost-fields
    • ember-frost-table
  • delete blueprint
  • update ember-frost-date-picker to latest version
  • update ember-frost-fields to latest version
  • update ember-frost-table to latest version
  • update ember-frost-demo-components to latest version
  • update ember-frost-fields to latest version
  • update ember-frost-table to latest version
  • update ember-prop-types to ^6.0.0 (or whatever the latest release is)
  • update ember-spread to ^4.0.0 (or whatever the latest release is)
  • update ember-frost-core to ^5.0.0 (or whatever the latest release is)
  • determine dependencies vs devDependencies
  • check whether these are specifically needed or not and remove if not, otherwise move to dependencies
    • ember-computed-decorators
    • ember-concurrency
    • ember-elsewhere
    • ember-truth-helpers
  • remove useLintTree from ember-cli-mocha configuration in ember-cli-build.js
  • see if this addresses Build issue with ember-cli-htmlbars-inline-precompile: 0.3.13 #464 or can
  • see if this addresses Refactor to remove usage of ember-simple-uuid dependency #489 or can

BOWER

  • move Faker to devDependencies of bower.json
  • move pretender to devDependencies of bower.json
  • remove codemirror (verified)
@notmessenger
Copy link
Contributor Author

JIRA: FROST-601

@notmessenger notmessenger changed the title Remove dependency management from blueprint and address other inconsistencies in package.json Address dependency management issues Dec 20, 2017
@juwara0 juwara0 mentioned this issue Jan 23, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant