-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new slice definitions for 'git' and dependancies #282
feat: add new slice definitions for 'git' and dependancies #282
Conversation
Diff of dependencies: slices/git.yaml@@ -1,8 +1,5 @@
-git-man
libc6
libcurl3t64-gnutls
-liberror-perl
libexpat1
libpcre2-8-0
-perl
zlib1g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Note that the Lint is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I just left two comments. let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks.
Are you sure you don't need liberror-perl
and perl
? If so, then there's just one small comment and it should be good to go
a152e26
to
705e014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add some tests too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes from Oct 24 Sprint
@lengau Thanks! Looks good. I replaced my test with yours, and added some of the changes I was working on since Cris' review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! One question about the pyftpd, but otherwise I'm ready to do a final sync to my branch as soon as we hear a go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python test also needs fixing it seems
The python tests are working now. It was a mismatch between python versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice and small, thanks! I left a few comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks
@clay-lake can you pls raise these changes to 24.10 too? |
Co-authored-by: Rafid Bin Mostofa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you very much!
…#282) Co-authored-by: Alex Lowe <[email protected]>
Will do! @cjdcordeiro #396 @lengau Merge is complete :) |
Synchronises this branch to the current state of the in-progress Ubuntu 24.04 slice PR. This is incomplete because there are currently questions about the tests.
Proposed changes
Add slices for git and dependency libcurl3t64-gnutls.
Related issues/PRs
Testing
Rudimentary smoke testing was provided by the script below. The bins slice successfully executes basic git operations, except for cloning a repository over http, which requires the core slice. Cloning over ssh has not yet been tested.
All testing was performed on a chiseled (ubuntu-24.04) container containing the following slices.
Checklist