Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git to ubuntu-22.04 release #372

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

lengau
Copy link

@lengau lengau commented Oct 20, 2024

Proposed changes

This adds the basics of git, not including perl scripts.

Related issues/PRs

Forward porting

TODO

Checklist

Additional Context

Copy link

github-actions bot commented Oct 20, 2024

Diff of dependencies:

slices/git.yaml
@@ -1,8 +1,5 @@
-git-man
 libc6
 libcurl3-gnutls
-liberror-perl
 libexpat1
 libpcre2-8-0
-perl
 zlib1g
slices/python3-pyftpdlib.yaml
@@ -1 +1 @@
-python3
+python3.10

@lengau
Copy link
Author

lengau commented Oct 20, 2024

@cjdcordeiro @rebornplusplus @clay-lake I'd like opinions on this before making the forward port. It's a bit different from #282, but still doesn't have the perl libs (it looks like perl might end up being even harder than Python to make good slices for). If this looks decent I'll add noble/oracular ports and pull it out of draft.

@rebornplusplus
Copy link
Member

@clay-lake we could talk about this and #282 in our 1:1 today, what do you think?

@clay-lake
Copy link

Looks like we doubled up on some work 😄

I have some additional changes to #282 on a personal branch that I use for testing. Let me bring those over to my PR and we can see if there is anything of value there.

@rebornplusplus Sounds good to me.

Synchronises this branch to the current state of the in-progress
Ubuntu 24.04 slice PR.

This is incomplete because there are currently questions about the tests.
@lengau lengau marked this pull request as ready for review December 12, 2024 00:32
@lengau
Copy link
Author

lengau commented Dec 12, 2024

@clay-lake this should be all set, matching your finalised noble slices.

Needed because pyftpdlib needs a file in /dev
@linostar linostar self-requested a review December 12, 2024 15:39
Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@linostar linostar requested a review from a team December 12, 2024 15:42
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good except the one comment I mentioned below.

slices/git.yaml Show resolved Hide resolved
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks ;)

@cjdcordeiro cjdcordeiro merged commit 2faf585 into canonical:ubuntu-22.04 Dec 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants