Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Forward Git and Dependencies #396

Conversation

clay-lake
Copy link

@clay-lake clay-lake commented Nov 25, 2024

Features included in this PR:

Copy link

github-actions bot commented Nov 25, 2024

Diff of dependencies:

slices/git.yaml
@@ -1,8 +1,5 @@
-git-man
 libc6
 libcurl3t64-gnutls
-liberror-perl
 libexpat1
 libpcre2-8-0
-perl
 zlib1g

Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of nitpicks.

tests/spread/integration/git/task.yaml Show resolved Hide resolved
tests/spread/integration/git/task.yaml Show resolved Hide resolved
@clay-lake clay-lake marked this pull request as ready for review December 9, 2024 07:48
@cjdcordeiro cjdcordeiro requested a review from linostar December 9, 2024 15:25
Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@linostar linostar requested a review from a team December 9, 2024 15:59
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@cjdcordeiro cjdcordeiro merged commit 1073c63 into canonical:ubuntu-24.10 Dec 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants