-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive #26502
Conversation
389569b
to
78fe87f
Compare
78fe87f
to
1367b21
Compare
Chromium major version is behind target branch (131.0.6778.85 vs 132.0.6834.15). Please rebase. |
1367b21
to
4e282f4
Compare
…sociated content is still alive This aids recall especially whilst the AIChatHistory feature flag is disabled
…ory is enabled since we don't have an async GetOrCreateConverationForContent
4e282f4
to
58de2e7
Compare
Released in v1.75.86 |
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#42510 (comment), ensured that the conversation session is being saved and not cleared when closing/re-opening the Recording.2024-12-10.005905.mp4As per the conversation with @petemill via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1733796984842519, |
This aids recall especially whilst the AIChatHistory feature flag is disabled
Resolves brave/brave-browser#42510
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: