Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep an AI Chat conversation alive if it has chat messages and its associated content is still alive #26502

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

petemill
Copy link
Member

@petemill petemill commented Nov 12, 2024

This aids recall especially whilst the AIChatHistory feature flag is disabled

Resolves brave/brave-browser#42510

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill self-assigned this Nov 12, 2024
@petemill petemill force-pushed the ai-chat-keep-conversation-alive branch 2 times, most recently from 389569b to 78fe87f Compare November 25, 2024 23:05
@petemill petemill marked this pull request as ready for review November 25, 2024 23:08
@petemill petemill assigned darkdh and unassigned darkdh Nov 25, 2024
@petemill petemill requested review from yrliou and darkdh November 25, 2024 23:09
@petemill petemill force-pushed the ai-chat-keep-conversation-alive branch from 78fe87f to 1367b21 Compare November 25, 2024 23:10
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Chromium major version is behind target branch (131.0.6778.85 vs 132.0.6834.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Dec 2, 2024
@petemill petemill force-pushed the ai-chat-keep-conversation-alive branch from 1367b21 to 4e282f4 Compare December 8, 2024 05:10
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Dec 8, 2024
…sociated content is still alive

This aids recall especially whilst the AIChatHistory feature flag is disabled
…ory is enabled since we don't have an async GetOrCreateConverationForContent
@petemill petemill force-pushed the ai-chat-keep-conversation-alive branch from 4e282f4 to 58de2e7 Compare December 8, 2024 05:23
@petemill petemill merged commit ef452b7 into master Dec 9, 2024
18 checks passed
@petemill petemill deleted the ai-chat-keep-conversation-alive branch December 9, 2024 07:31
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 9, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.86

petemill added a commit that referenced this pull request Dec 9, 2024
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
petemill added a commit that referenced this pull request Dec 9, 2024
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
petemill added a commit that referenced this pull request Dec 9, 2024
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
petemill added a commit that referenced this pull request Dec 9, 2024
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
petemill added a commit that referenced this pull request Dec 9, 2024
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
petemill added a commit that referenced this pull request Dec 10, 2024
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
petemill added a commit that referenced this pull request Dec 10, 2024
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
petemill added a commit that referenced this pull request Dec 10, 2024
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
petemill added a commit that referenced this pull request Dec 10, 2024
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.75.86 Chromium: 132.0.6834.33 (Official Build) nightly (64-bit)
-- | --
Revision | 0e6fd65d499de588288c231ca0aba711876f5022
OS | Windows 11 Version 24H2 (Build 26100.2454)

Using the STR/Cases outlined via brave/brave-browser#42510 (comment), ensured that the conversation session is being saved and not cleared when closing/re-opening the Leo panel as per the following:

Recording.2024-12-10.005905.mp4

As per the conversation with @petemill via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1733796984842519, Android is running into an issue due to #26951 which is only affecting Nightly, So we'll need to uplift the above into 1.74.x & 1.73.x to verify that the issue has been resolved. If it's still broken, we'll make a decision re: fixing or reverting it from 1.73.x.

kjozwiak pushed a commit that referenced this pull request Dec 10, 2024
…sociated content is still alive (uplift to 1.74.x) (#26942)

Merge pull request #26502 from brave/ai-chat-keep-conversation-alive

keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
kjozwiak pushed a commit that referenced this pull request Dec 10, 2024
…sociated content is still alive (uplift to 1.73.x) (#26943)

Merge pull request #26502 from brave/ai-chat-keep-conversation-alive

keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Chat conversations should persist when closing and opening panel on the same content
5 participants