Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep an AI Chat conversation alive if it has chat messages and its associated content is still alive (uplift to 1.74.x) #26942

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

petemill
Copy link
Member

@petemill petemill commented Dec 9, 2024

Uplift of #26502
Resolves brave/brave-browser#42510

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@petemill petemill added this to the 1.74.x - Beta milestone Dec 9, 2024
@petemill petemill self-assigned this Dec 9, 2024
@petemill petemill requested a review from a team as a code owner December 9, 2024 21:25
@petemill petemill force-pushed the ai-chat-keep-conversation-alive-v74 branch 2 times, most recently from a7734d6 to f889452 Compare December 9, 2024 23:42
keep an AI Chat conversation alive if it has chat messages and its associated content is still alive
@petemill petemill force-pushed the ai-chat-keep-conversation-alive-v74 branch from f889452 to 2aa9d7a Compare December 10, 2024 00:32
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.74.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #26502 (comment).

@kjozwiak kjozwiak merged commit 0515869 into 1.74.x Dec 10, 2024
16 checks passed
@kjozwiak kjozwiak deleted the ai-chat-keep-conversation-alive-v74 branch December 10, 2024 16:19
@brave-builds
Copy link
Collaborator

Released in v1.74.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants