Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Chat conversations should persist when closing and opening panel on the same content #42510

Closed
3 of 6 tasks
petemill opened this issue Nov 25, 2024 · 3 comments · Fixed by brave/brave-core#26502
Closed
3 of 6 tasks
Assignees
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@petemill
Copy link
Member

Description

AI Chat conversations should persist when closing and opening panel on the same content. This should be the case when the conversation history preference is enabled and when it is disabled.

Steps to reproduce

  1. Visit a website with content
  2. Open AI Chat (desktop sidebar or android panel0
  3. Ask a question about the content, e.g. "provide 1 emoji for this content, no other words"
  4. Wait for answer to complete (no input cursor in answer)
  5. Close panel
  6. Open panel again

Actual result

New blank conversation is shown

Expected result

Prior conversation is shown

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

1.73 - 1.75.36

Android device

n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.73.100 or higher for 1.73.x verification 👍

@hffvld
Copy link
Contributor

hffvld commented Dec 10, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 BP11.241025.006 release-keys
Brave build: 1.73.100
Chromium: 131.0.6778.108 (Official Build) (64-bit) 

STEPS:

  1. Follow the STR/TP from AI Chat conversations should persist when closing and opening panel on the same content #42510 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the conversation session is being saved and not cleared when closing/re-opening the Leo panel.

2024-12-10_13-55-05.mp4

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 11, 2024

Verification PASSED on

Brave | 1.73.101 Chromium: 131.0.6778.139 (Official Build) (64-bit)
-- | --
Revision | 45dae32a9fd5d259796f6c975ec055564fac7139
OS | Windows 10 Version 22H2 (Build 19045.5131)

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Status: Done
6 participants