Revert test fixes for AI-3786 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fixes were a failure, as they will now also reorder column vectors for e.g. text columns, without reordering the other column vectors at the same time. Diffcult to change the "canonicalization" routine without a fair amount fo effort as its 1) recursive so you have no context at present of the parent, and 2) we would need to know when we have a set of vectors which all must be reordered together (like column vectors), and adjust the routine accordingly.
For now, I have instead disabled the attachment field test. We currently have unit tests which test explicitly for serialisation and back-compatibility, and I will ask Lefos to add an API test to cover this case which should be equaivalent to this test anyway.