Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert test fixes for AI-3786 #108

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Revert test fixes for AI-3786 #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a69f91
revert canonoicalization changes, will disorder row-to-row comparissons
Nov 9, 2023
c3d02c7
Disable attachment field until we employ a more robust comparisson ro…
Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tests/testthat/setup.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,8 @@ canonicalizeActivityInfoObject <- function(tree, replaceId = TRUE, replaceDate =
list("Empty resources until we can ensure a sort order in the API.")
}
})
} else if (is.vector(x) && is.character(x)) {
# reorder character vectors (which are not lists) as sort order is not guaranteed by API
x <- x[order(x)]
}


x <- lapply(x, function(y) {
recursiveCanonicalize(y, path = paste(c(path, path), collapse = "."))
})
Expand Down
6 changes: 3 additions & 3 deletions tests/testthat/test-formField.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ test_that("Test deleteFormField()", {
identicalForm(fmSchm %>% deleteFormField(label = c("Text field 1", "Text field 5")), fmSchm2)
})

test_that("Test roundtrip of attachmentFieldSchema()", {
testField(attachmentFieldSchema(label = "A attachment FieldSchema field"))
})
# test_that("Test roundtrip of attachmentFieldSchema()", {
# testField(attachmentFieldSchema(label = "A attachment FieldSchema field"))
# })

test_that("Barcode fields can be created and uploaded and downloaded and are identical", {
testField(barcodeFieldSchema(label = "A barcode field"))
Expand Down
Loading