Merge pull request #108 from jamiewhths/fix-ai-3786

Revert test fixes for AI-3786
bedatadriven · Nov 9, 2023 · a7b45ae · a7b45ae
2 parents 47a61b7 + c3d02c7
commit a7b45ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/tests/testthat/setup.R b/tests/testthat/setup.R
@@ -72,12 +72,8 @@ canonicalizeActivityInfoObject <- function(tree, replaceId = TRUE, replaceDate =
             list("Empty resources until we can ensure a sort order in the API.")
           }
         })
-      } else if (is.vector(x) && is.character(x)) {
-        # reorder character vectors (which are not lists) as sort order is not guaranteed by API 
-        x <- x[order(x)]
       }
 
-
       x <- lapply(x, function(y) {
         recursiveCanonicalize(y, path = paste(c(path, path), collapse = "."))
       })

diff --git a/tests/testthat/test-formField.r b/tests/testthat/test-formField.r
@@ -65,9 +65,9 @@ test_that("Test deleteFormField()", {
   identicalForm(fmSchm %>% deleteFormField(label = c("Text field 1", "Text field 5")), fmSchm2)
 })
 
-test_that("Test roundtrip of attachmentFieldSchema()", {
-  testField(attachmentFieldSchema(label = "A attachment FieldSchema field"))
-})
+# test_that("Test roundtrip of attachmentFieldSchema()", {
+#   testField(attachmentFieldSchema(label = "A attachment FieldSchema field"))
+# })
 
 test_that("Barcode fields can be created and uploaded and downloaded and are identical", {
   testField(barcodeFieldSchema(label = "A barcode field"))