Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose timeout setting configuration from CRT #1065

Closed
2 tasks
harsh62 opened this issue Jul 25, 2023 · 4 comments
Closed
2 tasks

Expose timeout setting configuration from CRT #1065

harsh62 opened this issue Jul 25, 2023 · 4 comments
Assignees
@dayaffe
Labels
feature-request A feature should be added or improved.
Milestone
GA

Comments

@harsh62
Copy link
Member

harsh62 commented Jul 25, 2023

Describe the feature

A way to configure the equivalent of URLSessionConfiguration.timeIntervalForRequest and URLSessionConfiguration.timeoutIntervalForResource, either on a request or client configuration level?

Use Case

This was possible in AWS SDK for iOS whereas the AWS SDK for Swift doesn't support this configuration. Hence it creates a parity issue between Amplify versions.

Reference Issue: aws-amplify/amplify-swift#3004

Proposed Solution

Expose a configuration which would allow passing in custom timeout to CRT.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@harsh62 harsh62 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 25, 2023
@jbelkins jbelkins added this to the GA milestone Aug 1, 2023
@jbelkins jbelkins removed the needs-triage This issue or PR still needs to be triaged. label Aug 1, 2023
@grutts
Copy link

grutts commented Aug 18, 2023

Hi @harsh62 do you have an update on when this bug will be fixed? It remains a blocker to upgrading from Amplify 1.X which is currently in maintenance / end of life status.

@smivij
Copy link
Collaborator

smivij commented Sep 7, 2023

Adding needs-triage label again to revisit priority

@smivij smivij added the needs-triage This issue or PR still needs to be triaged. label Sep 7, 2023
@dayaffe
Copy link
Contributor

dayaffe commented Sep 11, 2023

Equivalent should be the ability to configure socketOptions as mentioned here. This value should be made configurable in the exposed wrapper here.

@dayaffe dayaffe removed the needs-triage This issue or PR still needs to be triaged. label Sep 11, 2023
@dayaffe dayaffe self-assigned this Sep 11, 2023
This was referenced Sep 20, 2023
Merged
Closed
Merged
@jbelkins
Copy link
Contributor

Released in AWS SDK for Swift 0.26.0

@grutts grutts mentioned this issue Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dayaffe dayaffe

Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
GA
Development

No branches or pull requests
5 participants
@jbelkins @dayaffe @harsh62 @grutts @smivij