-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWSCognitoNetworkPreferences cannot be found after upgrading to 2.x #3004
Comments
Hi please could you explain why this is tagged as a feature request and not a bug? This code worked in version 1.X |
Generally, adding a new API into a major version would be considered new feature. But you're right, it looks like v2 has removed the ability to configure these values, and with that has removed support for this use case. |
OK thank you for correcting the label. Do you have an estimate of when this will be prioritised? This bug blocks us from upgrading the library - so it would be good if it was fixed with ample buffer before V1 of the library left maintenance (May 31, 2024) |
@grutts Our team is reviewing the effort and changes that would needed to support this feature in Amplify V2. We will post an update on the issue in the next couple of weeks. |
Hi @harsh62 do you have an update please? |
Hello, do you have an estimate when this will be fixed now that awslabs/aws-sdk-swift#1065 has been merged? |
Hey @grutts We're planning on releasing a version of Amplify Swift early next week (likely Monday 10/16) that uses the updated version of AWS SDK for Swift. That won't contain the API allowing you to configure network preferences. Once that's released, we'll work on getting another version released containing an API that allows you to set the network preferences. I can't commit to any timelines, but I expect it to happen quickly at this point. We'll follow up with any updates. Thanks for your patience. |
Thanks @atierian - that's a very helpful update |
Hi @atierian do you have an update on the status of this? |
@grutts Thanks for your patience. The underlying changes that would be needed to support this feature has been released. Our team is currently prioritizing the design for this feature to be implemented. We will provide an update. I'll post an update on the issue. |
@grutts Quick Update: Meanwhile, if you get time, would you be able to test this in a feature branch |
Hi @harsh62 thanks for the update. We should be able to test this w/c 4 December |
The fix PR has been released in version 2.24.0. Feel open to reopen this ticket if you still having the issue. |
Describe the bug
We are upgrading our library from 1.x to 2.11.5
Our existing code will not build, as AWSCognitoNetworkPreferences can no longer be found.
We've read the upgrade instructions and amplify codebase but can't find references to the network preferences or an alternative configuration.
Steps To Reproduce
Expected behavior
It continues to work
Amplify Framework Version
2.11.5
Amplify Categories
Auth
Dependency manager
Swift PM
Swift version
5
CLI version
n/a
Xcode version
14.2
Relevant log output
No response
Is this a regression?
No
Regression additional context
No response
Device
iPad 10 simulator
iOS Version
15
Specific to simulators
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: