Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make connectTimeoutMs configurable #592

Merged
merged 5 commits into from
Sep 26, 2023
Merged

feat: make connectTimeoutMs configurable #592

merged 5 commits into from
Sep 26, 2023

Conversation

dayaffe
Copy link
Contributor

@dayaffe dayaffe commented Sep 20, 2023

Expose connectTimeoutMs so that it is configurable on the client.

Issue #

#1065
#1152

Description of changes

Ex. Usage

// I set timeout to 15_000 as an example but this could be any UInt32 number
let httpClientConfiguration = HttpClientConfiguration()
let crtEngine = CRTClientEngine(CRTClientEngineConfig(connectTimeoutMs: 15_000))
let httpClient = SdkHttpClient(engine: crtEngine, config: httpClientConfiguration)

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exposes the timeout setting on the CRT HTTP client, but can this setting be accessed when creating an AWS service client?

@dayaffe dayaffe merged commit 58eb4a3 into main Sep 26, 2023
7 checks passed
@dayaffe dayaffe deleted the day/expose-timeout branch September 26, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants