feat: add ability to configure timeout in AWSClientConfiguration #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayaffe
changed the title
2 tasks
|
/test |
sichanyoo
approved these changes
Sep 26, 2023
|
/test |
jbelkins
requested changes
Sep 26, 2023
|
|
||
| // MARK: - Timeout | ||
|
|
||
| func test_async_configureTimeoutOptionsFromParams() throws { |
There was a problem hiding this comment.
Do we also need a test for default timeout?
There was a problem hiding this comment.
Adding one now. Will check for 30_000 or 3_000 depending on the operating system the test is run on. There doesn't seem to be a way to force the OS in XCTest
There was a problem hiding this comment.
Removed this test as default timeout info is in CRT and not available to AWSClientConfiguration
|
/test |
|
/test |
jbelkins
approved these changes
Sep 26, 2023
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to configure connectTimeoutMs in AWSClientConfiguration.
Issue #
#1065
Companion PR: #592
Description of changes
Ex. Usage (S3)
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.