Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Java 8 from v2 examples #1531

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Conversation

jdoherty
Copy link
Contributor

Issue #1466

Description of changes:

Removed Java 8 from all examples.
Deployed and smoke tested all examples using Java 11 updating some README files as I went

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

💾 Artifacts Size Report

Module Version Size (KB)
powertools-common 2.0.0-SNAPSHOT 9.96
powertools-serialization 2.0.0-SNAPSHOT 16.94
powertools-logging 2.0.0-SNAPSHOT 45.80
powertools-tracing 2.0.0-SNAPSHOT 13.43
powertools-metrics 2.0.0-SNAPSHOT 14.29
powertools-parameters 2.0.0-SNAPSHOT 41.01
powertools-validation 2.0.0-SNAPSHOT 18.82
powertools-cloudformation 2.0.0-SNAPSHOT 16.82
powertools-idempotency 2.0.0-SNAPSHOT 43.31
powertools-large-messages 2.0.0-SNAPSHOT 17.65
powertools-batch 2.0.0-SNAPSHOT 16.88
powertools-examples-core-utilities-sam 2.0.0-SNAPSHOT 13640.27
powertools-examples-core-utilities-serverless 2.0.0-SNAPSHOT 13637.72

@scottgerring scottgerring changed the title chore: remove Java 8 issue #1466 chore: remove Java 8 from v2 examples Nov 30, 2023
@scottgerring scottgerring linked an issue Nov 30, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One little thing on the spotbugs build config but otherwise looks good 🙏 Thanks for cleaning up the docs + examples where you came across issues too!

.github/workflows/spotbugs.yml Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@e7757c7). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1531   +/-   ##
=====================================
  Coverage      ?   77.75%           
  Complexity    ?      623           
=====================================
  Files         ?       83           
  Lines         ?     2504           
  Branches      ?      270           
=====================================
  Hits          ?     1947           
  Misses        ?      469           
  Partials      ?       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdoherty jdoherty requested a review from scottgerring December 1, 2023 09:28
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scottgerring scottgerring merged commit 6141243 into v2 Dec 1, 2023
12 checks passed
@scottgerring scottgerring deleted the feature-remove-java8-examples branch December 1, 2023 09:31
@scottgerring scottgerring mentioned this pull request Dec 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Remove Java 8 support in examples for v2
3 participants