-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Java 8 from v2 examples #1531
Conversation
💾 Artifacts Size Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! One little thing on the spotbugs build config but otherwise looks good 🙏 Thanks for cleaning up the docs + examples where you came across issues too!
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #1531 +/- ##
=====================================
Coverage ? 77.75%
Complexity ? 623
=====================================
Files ? 83
Lines ? 2504
Branches ? 270
=====================================
Hits ? 1947
Misses ? 469
Partials ? 88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue #1466
Description of changes:
Removed Java 8 from all examples.
Deployed and smoke tested all examples using Java 11 updating some README files as I went
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.