Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): new logging module #1435

Merged
merged 77 commits into from
Dec 11, 2023
Merged

feat(v2): new logging module #1435

merged 77 commits into from
Dec 11, 2023

Conversation

jeromevdl
Copy link
Contributor

@jeromevdl jeromevdl commented Sep 17, 2023

Issue #, if available: #965

Description of changes:

  • abstract logging module with slf4j
  • log4j implementation
  • logback implementation
  • using the same fields as python/ts

Checklist

Breaking change checklist

Breaking change => v2

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl jeromevdl self-assigned this Sep 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@6b0fe5a). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1435   +/-   ##
=====================================
  Coverage      ?   87.21%           
  Complexity    ?      530           
=====================================
  Files         ?       61           
  Lines         ?     1854           
  Branches      ?      230           
=====================================
  Hits          ?     1617           
  Misses        ?      163           
  Partials      ?       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeromevdl
Copy link
Contributor Author

@scottgerring @msailes @mriccia it starts to have a good shape. It's quite well tested (unit and one e2e successfully migrated). I still need to test on Lambda and verify a few things, also want to see if we can improve more (removing dependencies). Already found a slf4j binding option to avoid service loader, will investigate more.

But, you can already start to look at it, as it's quite big...

@scottgerring
Copy link
Contributor

Pushed to queue! I've asked for some initial feedback on #1402 before I continue on it also ;)

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big diff. I've started comments here and will continue when the build passes again!

@jeromevdl jeromevdl changed the title feat: logging v2 feat(v2): new logging module Oct 24, 2023
docs/core/logging.md Outdated Show resolved Hide resolved
docs/core/logging.md Outdated Show resolved Hide resolved
docs/core/logging.md Outdated Show resolved Hide resolved
docs/core/logging.md Outdated Show resolved Hide resolved
docs/core/logging.md Outdated Show resolved Hide resolved
docs/core/logging.md Outdated Show resolved Hide resolved
docs/core/logging.md Outdated Show resolved Hide resolved
docs/core/logging.md Outdated Show resolved Hide resolved
docs/core/logging.md Outdated Show resolved Hide resolved
docs/core/logging.md Outdated Show resolved Hide resolved
scottgerring
scottgerring previously approved these changes Dec 11, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@jeromevdl jeromevdl merged commit b139a96 into v2 Dec 11, 2023
16 checks passed
@jeromevdl jeromevdl deleted the feat/logging-v2 branch December 11, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Coming soon
Development

Successfully merging this pull request may close these issues.

3 participants