-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): new logging module #1435
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #1435 +/- ##
=====================================
Coverage ? 87.21%
Complexity ? 530
=====================================
Files ? 61
Lines ? 1854
Branches ? 230
=====================================
Hits ? 1617
Misses ? 163
Partials ? 74 ☔ View full report in Codecov by Sentry. |
@scottgerring @msailes @mriccia it starts to have a good shape. It's quite well tested (unit and one e2e successfully migrated). I still need to test on Lambda and verify a few things, also want to see if we can improve more (removing dependencies). Already found a slf4j binding option to avoid service loader, will investigate more. But, you can already start to look at it, as it's quite big... |
Pushed to queue! I've asked for some initial feedback on #1402 before I continue on it also ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big diff. I've started comments here and will continue when the build passes again!
...ng/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspect.java
Show resolved
Hide resolved
...src/main/java/software/amazon/lambda/powertools/logging/internal/PowertoolsLoggedFields.java
Show resolved
Hide resolved
...src/main/java/org/apache/logging/log4j/layout/template/json/resolver/PowertoolsResolver.java
Outdated
Show resolved
Hide resolved
...ging-logback/src/main/java/software/amazon/lambda/powertools/logging/internal/JsonUtils.java
Outdated
Show resolved
Hide resolved
07c4381
to
a1e7f04
Compare
Co-authored-by: Scott Gerring <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
Issue #, if available: #965
Description of changes:
Checklist
Breaking change checklist
Breaking change => v2
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.