Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Remove Java 8 support in examples for v2 #1466

Open
1 of 2 tasks
scottgerring opened this issue Oct 10, 2023 · 1 comment · Fixed by #1531
Open
1 of 2 tasks

Maintenance: Remove Java 8 support in examples for v2 #1466

scottgerring opened this issue Oct 10, 2023 · 1 comment · Fixed by #1531
Assignees
Labels
good first issue Good for newcomers maintenance priority:3 Neutral - not a core feature or affects less than 40% of users status/staged-major-release This change will go with the next major release v2 Version 2
Milestone

Comments

@scottgerring
Copy link
Contributor

Summary

Maintaining examples for both Java 8 and Java 11+ is a significant time sink, particularly in terms of weaving configuration.

We should use v2 as an opportunity to remove support from the examples for Java 8, implicitly steering our users towards newer, more efficient Java runtimes.

Why is this needed?

  • Encourage best practices on AWS Lambda
  • Decrease maintenance burden

Which area does this relate to?

Other

Solution

No response

Acknowledgment

@scottgerring scottgerring added good first issue Good for newcomers maintenance priority:3 Neutral - not a core feature or affects less than 40% of users labels Oct 10, 2023
@scottgerring scottgerring moved this from Triage to Backlog in Powertools for AWS Lambda (Java) Oct 10, 2023
@jeromevdl jeromevdl changed the title Maintenance: Remove Java 8 examples from v2 Maintenance: Remove Java 8 support in examples for v2 Oct 10, 2023
@jeromevdl jeromevdl added the v2 Version 2 label Nov 8, 2023
@jdoherty jdoherty self-assigned this Nov 27, 2023
jdoherty added a commit that referenced this issue Nov 28, 2023
@scottgerring scottgerring linked a pull request Nov 30, 2023 that will close this issue
6 tasks
scottgerring pushed a commit that referenced this issue Dec 1, 2023
* Remove Java 8 issue #1466

* reverting pom to java 8 as change should only apply to examples

* updated workflow to not build examples in java 8 workflow

* updated syntax of workflow

* excluding examples from spotbugs check for java 8 build

* updated github actions workflow

* updated workflows to have a comma seperated list of examples modules when java 8 to exclude

* updating build syntax for non java 8

* updating gradle config for Java 11+

* updating the java version on spotbugs to 11
@scottgerring scottgerring added the status/staged-major-release This change will go with the next major release label Dec 7, 2023
@scottgerring
Copy link
Contributor Author

This will be released in v2

@scottgerring scottgerring added this to the v2 milestone Dec 21, 2023
@scottgerring scottgerring moved this from Backlog to Coming soon in Powertools for AWS Lambda (Java) Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers maintenance priority:3 Neutral - not a core feature or affects less than 40% of users status/staged-major-release This change will go with the next major release v2 Version 2
Projects
Status: Coming soon
Development

Successfully merging a pull request may close this issue.

3 participants