Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on 2.1 release #536

Closed
derberg opened this issue May 14, 2021 · 18 comments
Closed

Work on 2.1 release #536

derberg opened this issue May 14, 2021 · 18 comments
Labels
:shipit: Release An issue/PR containing details about a release of the specification

Comments

@derberg
Copy link
Member

derberg commented May 14, 2021

Release 2.1 is scheduled for June -> #513

Release branches:
https://github.com/asyncapi/spec/tree/2021-06-release
https://github.com/asyncapi/asyncapi-node/tree/2021-06-release
https://github.com/asyncapi/parser-js/tree/2021-06-release

Contribution guide:
https://github.com/asyncapi/spec/blob/master/CONTRIBUTING.md

Things to do for the release:

  • Remove spec docs duplication website#86 - @aayushmau5
  • automation setup. Release candidates artifacts publishing - @derberg
  • social media communication - @derberg
  • release notes - @derberg
  • press release - @Barbanio
  • review docs and examples and update if needed
  • draft release process basing on this first experience - @derberg
  • review proposals that were already there for some time and people got familiar with proposed solutions, help push what is possible towards Stage 3: Accepted
@derberg derberg added the :shipit: Release An issue/PR containing details about a release of the specification label May 14, 2021
@fmvilas
Copy link
Member

fmvilas commented May 14, 2021

I created a new milestone to track all the PRs that will be included in the 2.1.0 release: https://github.com/asyncapi/spec/milestone/17.

@fmvilas
Copy link
Member

fmvilas commented May 14, 2021

We should be setting a deadline date to include changes in the spec for this release. What about May 30?

@derberg
Copy link
Member Author

derberg commented May 14, 2021

@fmvilas you think we need it? if we have automation in place before the end of May and also I work on a release notes simultaneously and not leave it until the end, we should be able to accept things that come in later, I think. I think better to think about any deadline once we see there are enough features and then we say like "last 2 weeks" or something like that/

Thoughts?

I still dream about pushing #377 😅

@fmvilas
Copy link
Member

fmvilas commented May 14, 2021

Haha! I think it's important we communicate clearly that we're not just randomly choosing what goes in and what doesn't. A deadline might help.

@derberg
Copy link
Member Author

derberg commented May 14, 2021

The last time people asked I said that whatever reaches Stage 3: Accepted gets in. And it is on us to make sure that there is a setup that supports it.

@derberg
Copy link
Member Author

derberg commented May 14, 2021

cc @dalelane @magicmatatjahu

I'm tagging you folks as you should keep a closer look at this issue to learn about new additions if you want to add support to other tools you mentioned in the past, like java template or react component

@derberg
Copy link
Member Author

derberg commented May 14, 2021

draft PR with release notes opened asyncapi/website#260

@fmvilas I know you did an initial review of changes done between 2.0 tag and the latest master. Please provide the list of changes here or just contribute directly to the release notes article

@dalelane
Copy link
Collaborator

Can we add the IBM MQ protocol bindings that were defined in asyncapi/bindings#52 ?

If that's okay, I've gotten a couple of pull requests ready to start this:
#537
asyncapi/spec-json-schemas#58

@derberg
Copy link
Member Author

derberg commented May 18, 2021

@dalelane I think we have to 😅

@derberg
Copy link
Member Author

derberg commented May 20, 2021

automation of releases ready for review and merge:

in short: for june release, every merge to release branch from one of above repos will result in a tag like this v2.1.0-2021-06-release.1, of course this example represents tag on spec repo, parser and others have different version names. Most important is this part -2021-06-release.1 that will be always there and with every new merge bumped -2021-06-release.2. For spec we create only GitHub pre-release, and for parser and asyncapi-node we additionally produce npm package prerelease

@GeraldLoeffler
Copy link
Contributor

GeraldLoeffler commented May 26, 2021

requesting PR #545 to be included in spec 2.1

@GeraldLoeffler
Copy link
Contributor

requesting PR asyncapi/bindings#63 (the 2nd half of #545 ) to be included in spec 2.1

@derberg
Copy link
Member Author

derberg commented Jun 2, 2021

I updated release notes with stuff that was added long time ago, last year already to the master + new stuff.

asyncapi/website#260

I made some placeholders for topics that potentially could make it as not much review is needed in these cases, at least this is my assumption 😅

  • add IBM MQ to list of protocols in spec from @dalelane
  • add AnypointMQ to list of protocols + binding definition from @GeraldLoeffler
  • extend to examples object from @lbroudoux

I'm out tomorrow and next week, and @fmvilas is back after next week (so the same time I'm back, afaik). We will have 2 weeks until the end of June so 🤞🏼

@derberg
Copy link
Member Author

derberg commented Jun 22, 2021

For next release we need to extend bump action https://github.com/derberg/org-projects-dependency-manager/blob/main/lib/index.js#L79 to support "custom" branch against which the PR is created

@derberg
Copy link
Member Author

derberg commented Jun 22, 2021

Automation is almost ready. There is just a small rendering issue that we are solving now.

@derberg
Copy link
Member Author

derberg commented Jun 24, 2021

Messages examples from @lbroudoux are merged and RC published.

We just need to check if we can quickly fix issues with rendering nav for the spec in the website

@magicmatatjahu
Copy link
Member

ConverterJS - asyncapi/converter-js#44
React component with HTML template - asyncapi/asyncapi-react#362
Markdown template - asyncapi/markdown-template#129

@derberg
Copy link
Member Author

derberg commented Jun 29, 2021

Release is out asyncapi.com/blog/release-notes-2.1.0

@derberg derberg closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:shipit: Release An issue/PR containing details about a release of the specification
Projects
None yet
Development

No branches or pull requests

5 participants