feat!: support 2.1.0 version of spec #41
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
.eslintrc
Outdated
|
|
||
| overrides: | ||
| - files: "**/*.test.js" |
There was a problem hiding this comment.
maybe this has an error, try this https://github.com/asyncapi/generator/blob/b071cebe39beb50806cb2872e1256e7b7a328565/test/renderer.test.js#L1
There was a problem hiding this comment.
Nope 😞 Still 36% of duplication...
|
ok, last try, try again in esconfig but explicitly link to the test file that causes errors please |
|
you have some errors ineslint config file and pr testing is failing |
|
👏🏼 you decided to actually refactor rather than silet the rule, bravo 👏🏼 |
|
@derberg Yep, but current tests with this helper function aren't readable as were. |
|
I think https://github.com/asyncapi/modelina/blob/676726ac6385afbd901a5ebc0c5ad0c2a1064499/sonar-project.properties should do the trick, I just reminded myself about it that Jonas asked me for the same some day and this is how we fixed it |
|
I also had |
|
but with full filepath like jonas? |
|
@derberg Yes. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
getPayloadExamplesandgetHeadersExamplesfunctions to support thenameandsummaryfields from item ofmessage.examplesRelated issue(s)
Part of asyncapi/spec#536