-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support 2.1.0 spec version #129
Conversation
@@ -1,7 +1,8 @@ | |||
import { Text } from "@asyncapi/generator-react-sdk"; | |||
import { generateExample, getHeadersExamples, getPayloadExamples } from "@asyncapi/generator-filters"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain this change to a custom functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getHeadersExamples
or getPayloadExamples
only return the examples[*].headers
or examples[*].payload
, so we don't have corresponding name
or summary
for appropriate example. If we will have change from PR in @asyncapi/generator-filters
we must know that then it's a breaking change and we must update check all templates where we use the getHeadersExamples
and getPayloadExamples
. Making changes only here is safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getHeadersExamples
or getPayloadExamples
are more than what you wrote, if examples are not in examples
object, they are taken from payload or headers schema (if provided of course).
we can release generator-filters 2.0 🤷🏼 unless you already have your own versions of these functions in react component. Then we are just looking an effort we did in the past to move generic functions to @asyncapi/generator-filters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getHeadersExamples or getPayloadExamples are more than what you wrote, if examples are not in examples object, they are taken from payload or headers schema (if provided of course).
Functions in PR also are looking for that :)
we can release generator-filters 2.0 🤷🏼 unless you already have your own versions of these functions in react component. Then we are just looking an effort we did in the past to move generic functions to @asyncapi/generator-filters
So I will create PR in generator-filters
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🎉 This PR is included in version 0.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Support 2.1.0 spec version:
name
andsummary
.Example using the gemini example:
Related issue(s)
Part of asyncapi/spec#536