Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release pipeline for the spec #539

Merged
merged 5 commits into from
May 24, 2021
Merged

chore: add release pipeline for the spec #539

merged 5 commits into from
May 24, 2021

Conversation

derberg
Copy link
Member

@derberg derberg commented May 19, 2021

This PR introduces release automation for the spec using conventional commits spec and following the release cadence agreement.

assumptions:

  • all changes for release happen in release branch and every change in release branch produces a prerelease
  • merge from release into master branch triggers normal release, like minor or major
  • it is possible to merge from just a fork with for example fix PR and trigger patch release

See also: #536


Commit like fix: spelling mistake in Operations object description to master branch

Screenshot 2021-05-19 at 13 43 10

Results in a patch release (base was 2.0.1):
Screenshot 2021-05-19 at 13 45 21

Commit like feat: add something new in some non-release branch added to branch that doesn't't follow pattern with -release suffx

Screenshot 2021-05-19 at 14 36 21

did not trigger a release

Commit like feat: add something new in release branch is a branch that has 2021-06-release suffix

Screenshot 2021-05-19 at 15 56 57

Results in proper pre release v2.1.0-2021-06-release.1

Screenshot 2021-05-19 at 15 55 19

Another commit to release branch feat: add something more in release branch doesn't close bump from 2.1 to 2.2 but proper bump of suffix from 1 to 2

Screenshot 2021-05-19 at 16 02 47

---
branches:
- master
- name: 2021-06-release
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we need to be hardcoded here 🤷🏼 believe me or not, this is also strange for me but semantic-release package doesn't support regex here (I tried everything). I will make sure this step is part of the release process procedure

@derberg derberg mentioned this pull request May 20, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. It's exactly what I'd do manually but automated 💯

@derberg derberg merged commit dab7337 into asyncapi:master May 24, 2021
@derberg derberg deleted the spec-release-automation branch May 24, 2021 10:14
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member Author

derberg commented May 24, 2021

It is actually not included in the release. This was an unintentional release caused by the release automation initial run. 1.0 version of the spec was released a long time ago. The release mentioned by the bot was removed.

@derberg derberg removed the released label May 24, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member Author

derberg commented Jun 15, 2021

Not included in release 2.1 yet, 2.1 was mistakenly triggered by our automation.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants