-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto of the extensions #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percevalw
force-pushed
the
extension-refacto
branch
2 times, most recently
from
August 4, 2023 17:53
bdfa30a
to
3256ea7
Compare
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
…te for period bounds
Co-authored-by: Ariel Cohen <[email protected]> Co-authored-by: Perceval Wajsbürt <[email protected]>
percevalw
force-pushed
the
extension-refacto
branch
from
August 8, 2023 12:09
3256ea7
to
f07c510
Compare
…f with pytest-xdist
…f with pytest-xdist
Co-Authored-By: Perceval Wajsbürt <[email protected]> Co-Authored-By: Thomas Petit-Jean <[email protected]>
percevalw
force-pushed
the
extension-refacto
branch
3 times, most recently
from
September 12, 2023 23:29
b1e066d
to
aa750d0
Compare
percevalw
force-pushed
the
extension-refacto
branch
2 times, most recently
from
September 13, 2023 00:18
b4d3484
to
69517ac
Compare
…tter & label args Co-Authored-By: Perceval Wajsbürt <[email protected]> Co-Authored-By: Thomas Petit-Jean <[email protected]>
…f with pytest-xdist
percevalw
force-pushed
the
extension-refacto
branch
5 times, most recently
from
September 13, 2023 11:14
2c37c13
to
c8c43ed
Compare
percevalw
force-pushed
the
extension-refacto
branch
from
September 13, 2023 12:05
c8c43ed
to
52a5b91
Compare
This was referenced Sep 15, 2023
Closed
percevalw
added a commit
that referenced
this pull request
Sep 21, 2023
percevalw
added a commit
that referenced
this pull request
Sep 21, 2023
percevalw
added a commit
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the extensions of several pipelines to conform with #47.
The current changes are the following (this is still a draft):
Added
to_duration
method to convert an absolute date into a date relative to the note_datetime (or None)Changes
eds.emergency.gemsa
→emergency.gemsa
eds.emergency.ccmu
→emergency.ccmu
eds.emergency.priority
→emergency.priority
eds.charlson
→charlson
eds.elston-ellis
→elston-ellis
eds.SOFA
→sofa
eds.adicap
→adicap
eds.adicap
→adicap
eds.dates
now separate dates from durations. Each entity has its own label:spans["dates"]
→ entities labelled asdate
with aspan._.date
parsed objectspans["durations"]
→ entities labelled asduration
with aspan._.duration
parsed objectthe
mode
attribute of thespan._.date/duration
span._.date.bound
attributeto_datetime
now only return absolute dates, converts relative dates into absolute ifdoc._.note_datetime
is given, and None otherwiseChecklist
eds.measurements
eds.consultation-dates
value
extension(this PR has integrated the changes of #83)