-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate duration and datetime #83
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 94.06% 93.80% -0.26%
==========================================
Files 172 172
Lines 5085 5103 +18
==========================================
+ Hits 4783 4787 +4
- Misses 302 316 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I've rebased on master, moved durations to a new |
…on to separate span group
Closing as this was merged in #213 |
Description
Differentiate results of type duration and datetime.
Identified problem:
When applying the dates pipeline in batch, we obtain in the same column of the result dataframe objects of differnt data type.
Also, the to_datetime() method of a RelativeDate class returns either datetime or duration types depending if note_datetime is given
Some ideas:
to_datetime()
byto_pendulum()
or maybeto_datetime
should be a wraper ofto_duration()
andto_absolute()
Checklist