feat: allow Qualifiers to match on spangroups #128
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposition for allowing
Qualifiers
to look for matches in sentences present indoc.spans[key]
.It would extend the current
on_ents_only
argument by adding anotheron_spangroups
argumentAnother way of doing this could be to be more general with, e.g. a
on
parameter that could be set to tell the Qualifiers to match onHowever, this approach would induce many API breaking changes, so maybe the first approach is preferable
Checklist