Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Qualifiers to match on spangroups #128

Closed
wants to merge 6 commits into from

Conversation

Thomzoy
Copy link
Collaborator

@Thomzoy Thomzoy commented Sep 6, 2022

Description

Proposition for allowing Qualifiers to look for matches in sentences present in doc.spans[key].
It would extend the current on_ents_only argument by adding another on_spangroups argument

Another way of doing this could be to be more general with, e.g. a on parameter that could be set to tell the Qualifiers to match on

  • everything
  • all entities
  • entities present in spangroups
  • entities present in a subset of spangoups

However, this approach would induce many API breaking changes, so maybe the first approach is preferable

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

@Thomzoy Thomzoy requested a review from percevalw September 6, 2022 15:45
@Thomzoy
Copy link
Collaborator Author

Thomzoy commented Sep 7, 2022

Actualy some work was already done in the dates pipelines, so I took some inspiration from it

@percevalw
Copy link
Member

Closing as this was merged in #213

@percevalw percevalw closed this Sep 15, 2023
@percevalw percevalw deleted the match_on_spangroups branch November 14, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants