[core] Refactor: merge table-level ignore-delete options and filter delete data in writer layer #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Apr 1, 2024
| @@ -104,12 +101,8 @@ public void add(KeyValue kv) { | |||
| // refresh key object to avoid reference overwritten | |||
| currentKey = kv.key(); | |||
|
|
|||
| // ignore delete? | |||
| // ignore or retract? | |||
There was a problem hiding this comment.
remove this line? ignore what?
| WriterContainer<T> container = getWriterWrapper(partition, bucket); | ||
| container.writer.write(data); | ||
| if (container.indexMaintainer != null) { | ||
| container.indexMaintainer.notifyNewRecord(data); | ||
| } | ||
| } | ||
|
|
||
| protected abstract boolean skipData(T data); |
There was a problem hiding this comment.
ignore in TableWriteImpl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Skip delete data in
AbstractFileStoreWrite.Additional changes:
DeleteActiondoesn't change merge-engine and ignore-delete now. I think it equals toDELETEstatement, so it shouldn't have other semantics.MergeIntoActionchangeignore-deletetofalse.Tests
API and Format
Deprecate:
first-row.ignore-delete
deduplicate.ignore-delete
partial-update.ignore-delete
Add:
ignore-delete
Documentation