[flink] Add merge-engine check when executing row level batch update and delete #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zouxxyy
reviewed
Apr 9, 2024
|
|
||
| FIRST_ROW("first-row", "De-duplicate and keep the first row."); | ||
| FIRST_ROW("first-row", "De-duplicate and keep the first row.", true, false); |
There was a problem hiding this comment.
first-row does not need to support update
Zouxxyy
reviewed
Apr 9, 2024
|
|
||
| PARTIAL_UPDATE("partial-update", "Partial update non-null fields."), | ||
| PARTIAL_UPDATE("partial-update", "Partial update non-null fields.", false, false), |
There was a problem hiding this comment.
When using partial-update and no col contains agg, update is theoretically supported
JingsongLi
reviewed
Apr 9, 2024
|
|
||
| private final String value; | ||
| private final String description; | ||
|
|
||
| MergeEngine(String value, String description) { | ||
| private final boolean supportBatchUpdate; |
There was a problem hiding this comment.
Please do not modify this, this is public api, we don't need to expose here.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
partial-update and aggregate should not accept batch update because there is no UB and the aggregate result will be wrong.
It's not very clear about how to handle row level batch delete with partial update currently. Doris just delete the record. But it's not easy to delete the record because [core] Refactor: merge table-level ignore-delete options and filter delete data in writer layer #3128 and [core] Fix that ignore-delete option is not compatible with old delete records and LocalMergeOperator #3139 .
Linked issue: close #xxx
Tests
API and Format
Support batch update merge engines:
deduplicateandfirst-row.Support batch delete merge engines:
deduplicate.Documentation