[core] Fix that ignore-delete option is not compatible with old delete records and LocalMergeOperator #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzelin
changed the title
yuzelin
changed the title
JingsongLi
reviewed
Apr 2, 2024
| internalRow == null | ||
| ? null | ||
| : serializer.fromRow(internalRow).setLevel(level)); | ||
| // In older version, the delete records might be written into data file even when |
There was a problem hiding this comment.
Document clear: Version 0.7
| keyType, | ||
| valueType, | ||
| level, | ||
| CoreOptions.fromMap(schema.options()).ignoreDelete()); |
yuzelin
changed the title
|
We must figure out how to deal with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Before #3128 , the delete records can be write into data file even when
ignore-delete=true. So if using jar built after 3128 to read old data, the merge engine might throw exception. This PR fix it by adding filter in reader.Besides, records passed by
LocalMergeOperatoralso should be filtered.Also remove
changeIgnoreMergeEnginein merge_into action. Because I think merge_into should also obey the constrains of merge engine.Tests
API and Format
Documentation