-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectControl : Deprecate 36px default size #66898
SelectControl : Deprecate 36px default size #66898
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @parthVataliya16. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more things:
- In addition to this, there are a lot of code snippets in Markdown files across the repo that use SelectControl, and all of them need the prop. Otherwise the devs referring to those snippets would be copy pasting deprecated code. (I added some clarification in the original issue's procedure checklist.)
- We should also add the prop to the SelectControl usage in the Storybook story for the
Disabled
component. - In a previous PR I introduced a way to suppress warnings when the component's size is dependent on a parent component's size, and the parent component is responsible for logging the warning. I went ahead and added (70b6769) that to the relevant components here, which are DimensionControl and TreeSelect.
@PARTHVATALIYA Hi 👋 I need these merged soon, are you still available or do you need someone to take over? 🙂 |
Hello @mirka, Sorry for the inconvenience! I wasn’t able to resolve the deprecation warning. Could you please guide me, or feel free to take over if needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, thank you for your help here!
Part of #65751
What?
Deprecate the 36px default size in SelectControl.
Testing Instructions