Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Deprecate 36px default size #65751

Open
23 of 24 tasks
mirka opened this issue Sep 30, 2024 · 7 comments
Open
23 of 24 tasks

Components: Deprecate 36px default size #65751

mirka opened this issue Sep 30, 2024 · 7 comments
Assignees
Labels
[Package] Components /packages/components [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@mirka
Copy link
Member

mirka commented Sep 30, 2024

Part of #46741

In our transition process to the new 40px default sizes, we are now ready to officially start the deprecation period by logging console warnings.

List of components

Block Editor @mirka

Procedure

- [ ] Log deprecation warning
- [ ] Update unit tests
- [ ] Update Storybook (including all stories where the component is used)
- [ ] Update code snippets (Storybook, JSDoc, README)
- [ ] Changelog
- [ ] Add Dev Note tag

If used inside another wp-components component and the parent component is dictating the child component's size dynamically, the parent component is responsible for logging the deprecation warning. To suppress the redundant warning from the child component, add the __shouldNotWarnDeprecated36pxSize prop as shown here for the ToggleGroupControl used inside FontSizePicker.

Success criteria

- [ ] Unit tests must all be passing
- [ ] If used in a Storybook story for another component, it must have the prop so it isn't logging console warnings
@mirka mirka added [Package] Components /packages/components [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Sep 30, 2024
@mirka mirka self-assigned this Sep 30, 2024
@hbhalodia
Copy link
Contributor

Hi @mirka, I would like to pick some of the controls to add the deprecations. Should I wait until any of the PR get's merged to use the maybeWarnDeprecated36pxSize utility function?

Thank You,

@mirka
Copy link
Member Author

mirka commented Oct 9, 2024

@hbhalodia Awesome! Yes, I'll need to merge those first. I'll ping you when this is ready for contributors 🙏

@hbhalodia
Copy link
Contributor

Hi @mirka, I have raised the PR to deprecate 36px default size on BoxControl - #66704.

Thank You,

@hbhalodia
Copy link
Contributor

Hi @mirka, I have raised the PR to deprecate 36px default size on DimensionControl - #66705.

Thank You,

@vipul0425
Copy link
Contributor

Hi @mirka , I have raised the PR for RangeControl - #66721

Thank You 🙇

@PARTHVATALIYA
Copy link
Contributor

Hi @mirka, I have raised the PR for InputControl - #66897

Thank You!

@mirka
Copy link
Member Author

mirka commented Nov 22, 2024

@hbhalodia @PARTHVATALIYA Unit tests are not passing in the rest of your open PRs. That likely means that the unit tests for the component are not completely updated, and/or some components need a __shouldNotWarnDeprecated36pxSize added. Please check the updated Procedure section in the first issue comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

4 participants