-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Deprecate 36px default size #65751
Comments
Hi @mirka, I would like to pick some of the controls to add the deprecations. Should I wait until any of the PR get's merged to use the Thank You, |
@hbhalodia Awesome! Yes, I'll need to merge those first. I'll ping you when this is ready for contributors 🙏 |
@hbhalodia @PARTHVATALIYA Unit tests are not passing in the rest of your open PRs. That likely means that the unit tests for the component are not completely updated, and/or some components need a |
Part of #46741
In our transition process to the new 40px default sizes, we are now ready to officially start the deprecation period by logging console warnings.
List of components
Block Editor @mirka
Procedure
If used inside another wp-components component and the parent component is dictating the child component's size dynamically, the parent component is responsible for logging the deprecation warning. To suppress the redundant warning from the child component, add the
__shouldNotWarnDeprecated36pxSize
prop as shown here for the ToggleGroupControl used inside FontSizePicker.Success criteria
The text was updated successfully, but these errors were encountered: