Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputControl : Deprecate 36px default size #66897

Merged

Conversation

PARTHVATALIYA
Copy link
Contributor

@PARTHVATALIYA PARTHVATALIYA commented Nov 11, 2024

Part of #65751

What?

Deprecate the 36px default size in InputControl.

Testing Instructions

  • Unit tests pass
  • Storybook stories should not log console warnings
  • All code snippets in documentation (JSDoc, Storybook, README) should have the __next40pxDefaultSize prop enabled

Copy link

github-actions bot commented Nov 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: PARTHVATALIYA <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@PARTHVATALIYA PARTHVATALIYA changed the title Add the console warning for 36px size variation InputControl : Deprecate 36px default size Nov 11, 2024
@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components Needs Dev Note Requires a developer note for a major WordPress release cycle labels Dec 11, 2024
@mirka mirka self-requested a review December 11, 2024 22:44
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed this over the finish line, as done in #66898. Thank you for the first pass!

@mirka mirka enabled auto-merge (squash) December 11, 2024 23:27
@mirka mirka merged commit 795e9c2 into WordPress:trunk Dec 11, 2024
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants