PostLockedModal: Display preview link as part of the text #37852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: +68 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
This is excellent, thank you for tackling it head-on! Even as is, it's a vast improvement: (On a separate note, I can't get the gravatar to show up. One is assigned via email for my "editor" user, but it's not showing up. It's definitely unrelated to this PR, but just a curiosity I noticed.) A few small things: the size and style of the external link icon looks a bit off. Based on your implementation, it looks like it's technically a separate issue, one with the ExternalLink component itself, so it might be something we can look at separately. But the spacing and size looks a bit off: The width was set to 1.4em, so it's already being scaled outside of its base 24x24 size (which is generally a no-no, but seems correct for this particular utility icon). And just inspecting my way, I thought the following looked better:
It's smaller, it's inline with the text, and it feels almost like a glyph rather than an icon — which IMO is correct for "external link". These were the inspector styles:
Javier has a different max-width in his original mockups, the reason for that becomes clearer here, as it allows the text to wrap more nicely: The above here is at a 480px max-width, where we could use the So what's next?
After that, I think we could land this. Thanks again! |
|
Great work! There's is only one thing I miss. This is what I see when an admin takes over the post of an editor:
In this case, we'd need to add the name of the person that has control over the post. |
8 tasks
I think this is a separate issue and would be nice to discuss with folks working on the Components package.
I see this is already addressed in #37857. @javierarce, we display that message when the user's display name isn't available. Oddly, we have a user avatar but not a display name. I will look into this. |
8 tasks
|
I created a separate PR as a topic-starter on the external link component: #37859 |
|
Thank you, Joen. |
Mamaduka
force-pushed
the
try/post-takeover-modal-preview-link
branch
from
8e90080 to
dc4671e
Compare
|
I pushed some minor changes to avoid code duplication. @javierarce, it looks like the I think it might be better if we try to fix it separately. P.S. There's also a proposal for a new Post locking REST API - #37789. |
|
I think I also found the Gravatar issue that Joen mentioned. It looks like we're getting user's avatar but it's never used - |
This was referenced Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #37725.
PR updates Post Locked modal to display preview link inside the text instead of the separate button. It also shows the user's display name in bold.
How has this been tested?
Create two admin user accounts. Save a post as one user, then log in as the other user in an incognito mode and load the same post.
Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).