Simplify and unify a few modal dialogs. #37857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Type] Code Quality
|
I wonder, instead of scoping the max-widths for these modals to only take beyond the mobile breakpoint, perhaps we should just keep them unqueried, and then set |
|
Size Change: +27 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
8 tasks
Mamaduka
approved these changes
Jan 11, 2022
jasmussen
force-pushed
the
fix/modal-scaling
branch
from
94239b2 to
c8a361b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #37821 and #37852, part of #37725.
We add max-widths to a few of the modal dialogs we have, but those max-widths should only apply when the modal isn't meant to be fullscreen, which it is on mobile. That results in a not quite fullscreen modal:
This PR fixes it for Page List to menu item link conversion dialogs, legacy gallery upgrade dialogs, and post takeover dialogs. Here's the page list after:
It also unifies and simplifies a bit the code used. It's really starting to look like we could move towards something like #34153 for a bunch of these.
How has this been tested?
Ideally test the page list conversion, the gallery upgrade, and the post takeover modals.
Checklist:
*.native.jsfiles for terms that need renaming or removal).