Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post locking screen not always displayed #83426

Closed
dsas opened this issue Oct 24, 2023 · 8 comments
Closed

Post locking screen not always displayed #83426

dsas opened this issue Oct 24, 2023 · 8 comments
Assignees
Labels
[Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@dsas
Copy link
Contributor

dsas commented Oct 24, 2023

Quick summary

A dotorg install displays this dialog when two users try to edit the same page.

Screenshot 2023-10-27 at 09 07 24

This dialog does not appear on dotcom. A similar one can be sometimes triggered.

Is the modal broken?

Once the dialog is being displayed, I think it's probably broken when using the calypso page/post editor.

The iframe bridge has some code related to making the post locking modal work across despite modals.

It assumes that the post locked dialog has three buttons but since WordPress/gutenberg#37852 it only has two.

This means it's not overriding the all posts link to bust out the iframe and it's not modifying the take over button to add the frame-nonce.

Steps to reproduce

  1. Create a simple site and add an extra editor user to it
  2. As one user create a new post and save it as a draft. Leave this window open
  3. In a second profile/private window log in as the second user and then open the same draft as the other user has open.

What you expected to happen

A dialog to appear to the second user warning them that someone is already working on this page/post. Like the initial screenshot (made using a dotorg install).

What actually happened

Nothing, I could use the editor as normal.

Impact

One

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

In a dotorg install pressing 'Take over' will mean the original user will see a dialog warning them of this:

Screenshot 2023-10-27 at 09 13 17

This dialog does eventually appear in dotcom, if you start typing in both windows.

@cuemarie
Copy link

Hey @dsas ! Would you like KitKat to replicate this further for you as part of triage? If so, I could use some info on what's expected/what's actually happening - I can't quite tell from the report above what to look for in that test. Once I know that, happy to test across Simple & Atomic to add further notes/screenshots!

@cuemarie cuemarie moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Oct 26, 2023
@cuemarie cuemarie added [Feature] Post/Page Editor The editor for editing posts and pages. [Status] Needs Author Reply [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. labels Oct 26, 2023
@dsas dsas changed the title Update ETK post-locking to match GB Post locking screen not always displayed Oct 27, 2023
@dsas
Copy link
Contributor Author

dsas commented Oct 27, 2023

Hey @cuemarie. Sorry, this was a problem I found while looking at some related code but couldn't get to the affected modal dialog as the user. I've explored the problem a little more and rewritten the issue to be more user-centric.

@cuemarie
Copy link

Much appreciated @dsas !

@cuemarie
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
Replicated as described! I was never notified that someone was already editing a post. I did eventually run into the notification that "Someone else has taken over this post".

Screen.Capture.on.2023-10-30.at.16-08-19.mp4

📌 ACTIONS

  • Triaged

@cuemarie cuemarie added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Oct 30, 2023
@cuemarie cuemarie moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 30, 2023
@davemart-in
Copy link
Contributor

I'm not sure why this is stripped out. This can be super handy in situations where multiple people are trying to edit a page/post. Otherwise edits can be lost.

@BogdanUngureanu BogdanUngureanu self-assigned this Oct 21, 2024
@BogdanUngureanu
Copy link
Contributor

I think this is on purpose in D49393-code and only limited to a12s as a way to prevent blocking users during support sessions.

I've tried to reproduce it with my test (non-a8c) accounts and I couldn't reproduce it.

Closing this. :)

@inaikem
Copy link
Contributor

inaikem commented Oct 22, 2024

@BogdanUngureanu, we're running some group triage at the moment and came across this issue. Did you resolve it as part of your Dotcom Groundskeeping rotation this week? Thanks!

@BogdanUngureanu
Copy link
Contributor

@inaikem yes, I investigated it yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

5 participants