Combine "preview" and "publish" Tips copy

[melchoyce]

...To account for the preview button being disabled.

See #8061.

[Soean]

The snapshot test in the post-preview-button component fails. We need to update the snapshots

This command updates this snapshot:
npm run test-unit -- --updateSnapshot --testPathPattern /packages/editor/src/components/post-preview-button/test

[melchoyce]

Updated the tests, thanks @Soean

[melchoyce]

I can't seem to update the post-publish-button tests? I get a bunch of errors when I try to run npm run test-unit -- --updateSnapshot --testPathPattern /packages/editor/src/components/post-publish-button/test.

[melchoyce]

Okay yeah actually removing that fourth tip broke it, oops. @talldan any idea how I'd remove a tip?

[melchoyce]

Should we change the position or keep as-is?

[sarahmonster]

Copy-wise: looks good to me!

Position-wise: it feels like it's floating in midair (both the blue dot, and the tip itself). I wouldn't go bananas trying to get it to a perfect position, but maybe if we could at least centre the dot between the two buttons in question?

[noisysocks]

@melchoyce: 71aa3a0 removes the fourth tip and c51ce65 positions the third tip in the middle of the two buttons.

I didn't spend any time making the position pixel perfect. It's difficult to have tips appear exactly where you want them for all languages and viewport sizes, but if you'd like to fiddle with it, you could try giving the new wrapper <div> a className and then adjusting the left and right of .wrapper-div .nux-dot-tip using CSS.

[mapk]

I just tested this. While its not lined up to pixel perfection, I don't think that's a big deal.

The only suggestion I have is the tip says,

"...use the “Preview” button to see how it will look to readers."

That was a bit awkward for me. Can we say,

"...use the "Preview" button to see how it will look for others."

[kjellr]

"...use the "Preview" button to see how it will look for others."

The use of "others" here is a bit vague. Would it makes sense to say:

...use the "Preview" button to see how it will look to site visitors.

Or just:

...use the "Preview" button to see how it will look on your site.

[0aveRyan]

I proposed on #9256, but adding here as well.

Want to see how your work will be displayed? Use the "Preview" button. Ready to publish your work (or schedule for later)? Use the "Publish" button.

[boemedia]

I proposed on #9256, but adding here as well.

Want to see how your work will be displayed? Use the "Preview" button. Ready to publish your work (or schedule for later)? Use the "Publish" button.

I really like this copy, since it short and sweet. Maybe remove ‘your work from the third sentence to make it even shorter, and make that one ‘When you’re ready to publish or schedule, use the “Publish” button.’

[0aveRyan]

Sounds good!

Want to see how your work will be displayed? Use the "Preview" button. When you’re ready to publish or schedule, use the “Publish” button.

[noisysocks]

I rebased this and updated the copy to be what @0aveRyan suggested above.

[mapk]

While there are tip changes coming that will deprecate this current rendition, this looks fine. I don't have a problem merging it until the new improved tips are implemented.

[noisysocks]

Let's close this out as we're intending to get rid of tips altogether, per #16315.