Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch BasicDropdown icon accessibility #106

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Patch BasicDropdown icon accessibility #106

merged 2 commits into from
Jul 17, 2024

Conversation

benkates
Copy link
Contributor

@benkates benkates commented Jul 9, 2024

What's in this pull request

  • Component update

Description

Add aria-hidden="true" to icon so screenreaders don't pick it up

Before submitting, please check that you've

  • Formatted your code correctly (i.e., prettier cleaned it up)
  • Documented any new components or features
  • Added any changes in this PR to the CHANGELOG.md Next section

@benkates benkates requested a review from mitchthorson July 9, 2024 20:55
@benkates benkates merged commit 3496dba into main Jul 17, 2024
1 check passed
@benkates benkates deleted the patch-dropdown-icon-a11y branch July 17, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchthorson mitchthorson mitchthorson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benkates @mitchthorson