Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch BasicDropdown icon accessibility #106

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Patch BasicDropdown icon accessibility #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ad3f3a
patch dropdown icon a11y
benkates Jul 9, 2024
946b0e7
Merge branch 'main' into patch-dropdown-icon-a11y
benkates Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Next

- Patch: Update BasicDropdown with better accessibility (icon hidden from screen readers)
- Feature: GitHub source links for components via [@etchteam/storybook-addon-github-link](https://storybook.js.org/addons/@etchteam/storybook-addon-github-link) in storybook docs

## v0.10.2
Expand Down
2 changes: 1 addition & 1 deletion src/lib/BasicDropdown/BasicDropdown.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
{/if}
{/each}
</select>
<div class="icons">
<div class="icons" aria-hidden="true">
<span class="dropdown-chevron">
<slot name="icon">
{#if variant === "primary"}
Expand Down