Merge pull request #106 from UrbanInstitute/patch-dropdown-icon-a11y

Patch BasicDropdown icon accessibility
UrbanInstitute · Jul 17, 2024 · 3496dba · 3496dba
2 parents 3d31c4a + 946b0e7
commit 3496dba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Next
 
+- Patch: Update BasicDropdown with better accessibility (icon hidden from screen readers)
 - Feature: GitHub source links for components via [@etchteam/storybook-addon-github-link](https://storybook.js.org/addons/@etchteam/storybook-addon-github-link) in storybook docs
 
 ## v0.10.2

diff --git a/src/lib/BasicDropdown/BasicDropdown.svelte b/src/lib/BasicDropdown/BasicDropdown.svelte
@@ -73,7 +73,7 @@
         {/if}
       {/each}
     </select>
-    <div class="icons">
+    <div class="icons" aria-hidden="true">
       <span class="dropdown-chevron">
         <slot name="icon">
           {#if variant === "primary"}
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ @@
     ## Next
+    - Patch: Update BasicDropdown with better accessibility (icon hidden from screen readers)
     - Feature: GitHub source links for components via [@etchteam/storybook-addon-github-link](https://storybook.js.org/addons/@etchteam/storybook-addon-github-link) in storybook docs
     ## v0.10.2
@@ Expand Down @@