Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Themes] Remove template type flag and related functionality #5100

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

jamesmengo
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Unused types (3)

Filename types
packages/theme/src/cli/services/generate/blocks.ts BlockGeneratorOptions
packages/theme/src/cli/services/generate/sections.ts SectionGeneratorOptions
packages/theme/src/cli/services/generate/templates.ts TemplateGeneratorOptions

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.28% 8781/11664
🟡 Branches 70.59% 4281/6065
🟡 Functions 74.98% 2295/3061
🟡 Lines 75.84% 8302/10947

Test suite run success

1981 tests passing in 896 suites.

Report generated by 🧪jest coverage report action from e92b50c

Base automatically changed from jm/template_generator to jm/generators December 16, 2024 21:57
@jamesmengo jamesmengo merged commit e92b50c into jm/generators Dec 16, 2024
24 of 27 checks passed
@jamesmengo jamesmengo deleted the jm/remove_type_param branch December 16, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant