-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Themes] Add support for generating liquid and JSON section files #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2024
5 tasks
Unused types (3)
|
jamesmengo
force-pushed
the
jm/blocks_generator
branch
from
December 12, 2024 02:00
faabbfc
to
05db127
Compare
jamesmengo
force-pushed
the
jm/section_generator
branch
from
December 12, 2024 02:00
ac21ac0
to
1ee4afc
Compare
Coverage report
Test suite run success1981 tests passing in 896 suites. Report generated by 🧪jest coverage report action from 9a241ab |
jamesmengo
force-pushed
the
jm/blocks_generator
branch
from
December 12, 2024 17:52
05db127
to
594b08b
Compare
jamesmengo
force-pushed
the
jm/section_generator
branch
from
December 12, 2024 17:52
1ee4afc
to
9a241ab
Compare
jamesmengo
force-pushed
the
jm/section_generator
branch
from
December 12, 2024 23:48
9a241ab
to
3c39897
Compare
This was referenced Dec 12, 2024
Had a very quick play with this. A couple of comments
|
Both section filename and schema "name" property match. This will result in users changing one or the other almost every time this command is used. I'd recommend converting the name to kebab case for the filename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Adds support for generating theme sections with both Liquid and JSON file types, providing developers with more flexibility when creating new theme sections.
WHAT is this pull request doing?
generateSection
service to handle section file creationHow to test your changes?
theme generate section
and follow the promptsMeasuring impact
Checklist