-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Themes] Add template generation with liquid and json support #5099
Conversation
Unused types (3)
|
Coverage report
Test suite run success1981 tests passing in 896 suites. Report generated by 🧪jest coverage report action from 1bc4bba |
I really like that if a template doesn't already exist you skip the "Name of the template" question. Good thinking there! On that note though - if a template doesn't already exist and you generate a Liquid one, it provides a section schema. It should be empty as templates don't have schemas. Also this is scope creep, but I deleted Another thought - I appreciate at the moment we're just appending the template name to Finally moving on from |
Since you can already use separate flags I'm not certain if this is necessary, but it would be really nice and even faster to use if I could let the cli parse my decisions from a filename
|
Metaobject templates are missing Also customers is a directory, so should have templates like |
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist