Clarify upgrade advice for bazelisk #22171
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BetsyMcPhail
commented
Nov 13, 2024
There was a problem hiding this comment.
+@nicolecheetham for review
Reviewable status: LGTM missing from assignee nicolecheetham, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @BetsyMcPhail)
BetsyMcPhail
added
the
release notes: none
There was a problem hiding this comment.
It appears tools/workspace/bazelisk/repository.bzl line 22 is too long so Jenkins jobs fails. The line is 79 characters. Should just need to be a word or two shorter. Also, the instructions are still not clear how to go about manually updating the checksums. Specifically, how to get/create the new checksums.
Reviewable status: LGTM missing from assignee nicolecheetham, needs platform reviewer assigned, needs at least two assigned reviewers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #22087
When performing upgrades using the semi-automated script, most externals only require the standard pre-merge jobs to test. In the case of bazelisk, however, an unprovisioned Linux job should also be run. Add a reminder to the documentation.
This change is