Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore iceoryx_binding_c rosdep key #50

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

sloretz
Copy link
Collaborator

@sloretz sloretz commented Mar 25, 2022


This change is Reviewable

@sloretz sloretz self-assigned this Mar 25, 2022
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Not entirely clear on why it's ignored, but good enough for me!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sloretz)

@EricCousineau-TRI
Copy link
Collaborator

I notice that CI in #22 is failing, for seemingly related reason.

Should this be merged in?

Base automatically changed from sloretz__include_heuristic to develop March 29, 2022 17:59
@sloretz sloretz marked this pull request as ready for review March 29, 2022 17:59
Signed-off-by: Shane Loretz <[email protected]>
Copy link
Collaborator Author

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ignored because a package depends oniceoryx_binding_c, but iceoryx_binding_c doesn't install its package.xml. When rosdep can't find a package.xml for a package it assumes it's a system dependency and errors when there's no rosdep key for it.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sloretz)

Copy link
Collaborator Author

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sloretz)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants