Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boot error in analytics config-checker code... #14

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

JSegrave-IBM
Copy link
Collaborator

Fixing this error:

AssertionError: 
CONFIG ISSUE (1) : prometeo_config.json : One or more of the 'gas_limits' configurations [8, 6, 4, 2, 1] is incompatible with the range of the 'nitrogen_dioxide' sensor (min: 0.05, max: 10).
Please note that sensors must have a much larger range than the limits - 2x being a minimum.

Sensors can now report 'range exceeded', so the config-checker code no longer needs to enforce the above as a safety constraint. However they do still recommend it, via this non-fatal warning:

WARNING:GasExposureAnalytics:prometeo_config.json : One or more of the 'gas_limits' configurations [8, 6, 4, 2, 1] is very close to the range of the 'nitrogen_dioxide' sensor (min: 0.05, max: 10).
Sensors shoud have a much larger range than the limits - e.g. 2x at a minimum.

…o longer needs to *enforce* the 'limits should be at least double the sensor range' as a safety constraint. (However they do still *recommend* it, via a warning).
@JSegrave-IBM
Copy link
Collaborator Author

@lidderupk @narengan - here's the fix to that boot-up issue we saw tonight. Would you mind reviewing/merging this fix please? Thanks!

@JSegrave-IBM
Copy link
Collaborator Author

Linking issue #117

Copy link
Member

@upkarlidder upkarlidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks John.

@upkarlidder upkarlidder merged commit 381c2a2 into Pyrrha-Platform:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants