Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor matrix file I/O #184

Merged
merged 27 commits into from
Sep 20, 2024
Merged

Refactor matrix file I/O #184

merged 27 commits into from
Sep 20, 2024

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Sep 17, 2024

The idea behind this PR is to have matrix import from file utilities in Re::Solve return a ready to use matrix in proper CSR or sorted COO format. That could help simplify some of the code in Re::Solve that was added to support unsorted COO with duplicates to CSR conversions.

What i hope to accomplish is:

@pelesh pelesh added bug Something isn't working enhancement New feature or request labels Sep 17, 2024
@pelesh pelesh requested review from maksud and kswirydo September 17, 2024 14:52
@pelesh pelesh self-assigned this Sep 17, 2024
@pelesh
Copy link
Collaborator Author

pelesh commented Sep 17, 2024

This PR touches a large number of files but most of the changes are trivial. Significant changes are only in matrix/io.cpp file.

@pelesh pelesh marked this pull request as ready for review September 18, 2024 02:04
@pelesh
Copy link
Collaborator Author

pelesh commented Sep 18, 2024

All tests pass with NVIDIA and AMD GPUs.

CC: @superwhiskers

resolve/matrix/io.cpp Show resolved Hide resolved
resolve/matrix/MatrixHandler.cpp Show resolved Hide resolved
resolve/matrix/Csr.cpp Show resolved Hide resolved
resolve/matrix/Csr.cpp Show resolved Hide resolved
resolve/matrix/Coo.hpp Show resolved Hide resolved
resolve/matrix/Coo.cpp Show resolved Hide resolved
resolve/matrix/io.cpp Outdated Show resolved Hide resolved
resolve/matrix/io.cpp Outdated Show resolved Hide resolved
resolve/matrix/io.hpp Outdated Show resolved Hide resolved
examples/r_KLU_GLU.cpp Outdated Show resolved Hide resolved
resolve/matrix/io.cpp Outdated Show resolved Hide resolved
@maksud
Copy link
Collaborator

maksud commented Sep 20, 2024

Functionality wise more concise. Thanks, all test works

Copy link
Collaborator

@maksud maksud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
3 participants