-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor matrix file I/O #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR touches a large number of files but most of the changes are trivial. Significant changes are only in |
All tests pass with NVIDIA and AMD GPUs. CC: @superwhiskers |
kswirydo
reviewed
Sep 18, 2024
maksud
reviewed
Sep 19, 2024
kswirydo
approved these changes
Sep 19, 2024
maksud
reviewed
Sep 20, 2024
maksud
reviewed
Sep 20, 2024
maksud
reviewed
Sep 20, 2024
maksud
reviewed
Sep 20, 2024
Functionality wise more concise. Thanks, all test works |
maksud
reviewed
Sep 20, 2024
maksud
reviewed
Sep 20, 2024
maksud
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to have matrix import from file utilities in Re::Solve return a ready to use matrix in proper CSR or sorted COO format. That could help simplify some of the code in Re::Solve that was added to support unsorted COO with duplicates to CSR conversions.
What i hope to accomplish is:
nnz_expanded_
sparse matrix member variable and supporting accessor methods (i.e. resolve document invariants fornnz_expanded_
or remove it entirely #166).ReSolve::io::writeMatrixToFile
callsSparse::print
, which writes out 0-indexed coordinates of matrix data, when the matrix market coordinate format is 1-indexed #179.Sparse::updateData
reads nnz fromnnz_expanded_
if theis_expanded_
flag is set #176.