Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming matrix::Sparse::copyData to matrix::Sparse::SyncData #187

Closed
pelesh opened this issue Sep 20, 2024 · 0 comments · Fixed by #199
Closed

Consider renaming matrix::Sparse::copyData to matrix::Sparse::SyncData #187

pelesh opened this issue Sep 20, 2024 · 0 comments · Fixed by #199
Assignees
@maksud @kswirydo @pelesh
Labels
enhancement New feature or request question Further information is requested

Comments

@pelesh
Copy link
Collaborator

pelesh commented Sep 20, 2024

Just a comment: copyData sounds like we are providing the data to copy or something. Basically, you are telling the matrix containers to sync data between device and host. So, something that sounds like that may be a good option. For example, syncData.

Originally posted by @maksud in #184 (comment)
@pelesh pelesh mentioned this issue Sep 20, 2024
Merged
4 tasks
@pelesh pelesh self-assigned this Sep 20, 2024
@pelesh pelesh added enhancement New feature or request question Further information is requested labels Sep 20, 2024
@pelesh pelesh mentioned this issue Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maksud maksud

@kswirydo kswirydo

@pelesh pelesh

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename copyData -> syncData and ensure correct flags set when syncing ORNL/ReSolve
3 participants
@maksud @kswirydo @pelesh