Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReSolve::io::writeMatrixToFile calls Sparse::print, which writes out 0-indexed coordinates of matrix data, when the matrix market coordinate format is 1-indexed #179

Closed
superwhiskers opened this issue Jul 22, 2024 · 1 comment · Fixed by #184
Assignees
Labels
bug Something isn't working

Comments

@superwhiskers
Copy link
Collaborator

the implementation of ReSolve::io::writeMatrixToFormat writes the matrix market coordinate data as 0-indexed, when it is specified to be 1-indexed. this makes matrix market files generated by resolve unreadable to any matrix market implementation, including resolve itself

@superwhiskers superwhiskers added the bug Something isn't working label Jul 22, 2024
@pelesh pelesh mentioned this issue Sep 17, 2024
4 tasks
@pelesh
Copy link
Collaborator

pelesh commented Sep 18, 2024

We use the print function mainly for debugging and there we want 0-based indices. In #184, I added option to choose 1- or 0-based indexing with 1-based indexing used in matrix export.

@pelesh pelesh self-assigned this Sep 18, 2024
@pelesh pelesh closed this as completed in b326fbd Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants