Hr/add limiters #376
Merged
Hr/add limiters #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigomha
reviewed
May 28, 2024
|
|
||
| function limit_output_current(limiter :: PSY.MagnitudeOutputCurrentLimiter, Id_cnv_ref :: Union{Float64, ForwardDiff.Dual}, Iq_cnv_ref :: Union{Float64, ForwardDiff.Dual}) | ||
| limit_value = PSY.get_I_max(limiter) | ||
| if (Id_cnv_ref^2 + Iq_cnv_ref^2)^(1/2) > limit_value |
There was a problem hiding this comment.
Consider using sqrt(Id_cnv_ref^2 + Iq_cnv_ref^2) rather than (Id_cnv_ref^2 + Iq_cnv_ref^2)^(1/2)
rodrigomha
reviewed
May 28, 2024
| @@ -0,0 +1,56 @@ | |||
| function limit_output_current(limiter :: Nothing, Id_cnv_ref :: Union{Float64, ForwardDiff.Dual}, Iq_cnv_ref :: Union{Float64, ForwardDiff.Dual}) | |||
There was a problem hiding this comment.
You can replace Union{Float64, Forwardiff.Dual} with ACCEPTED_REAL_TYPES
rodrigomha
reviewed
May 28, 2024
| function limit_output_current(limiter :: PSY.MagnitudeOutputCurrentLimiter, Id_cnv_ref :: Union{Float64, ForwardDiff.Dual}, Iq_cnv_ref :: Union{Float64, ForwardDiff.Dual}) | ||
| limit_value = PSY.get_I_max(limiter) | ||
| if (Id_cnv_ref^2 + Iq_cnv_ref^2)^(1/2) > limit_value | ||
| Id_cnv_ref2 = limit_value*cos(theta) |
There was a problem hiding this comment.
This shouldn't work. I don't see theta defined. Also, consider using θ (\theta), rather than theta.
rodrigomha
reviewed
May 28, 2024
| limit_value = PSY.get_I_max(limiter) | ||
| gain = PSY.get_kw(limiter) | ||
| theta = atan(Iq_cnv_ref, Id_cnv_ref) | ||
| if (Id_cnv_ref^2 + Iq_cnv_ref^2)^(1/2) > limit_value |
rodrigomha
reviewed
May 28, 2024
| Id_cnv_ref2 = Id_cnv_ref | ||
| Iq_cnv_ref2 = Iq_cnv_ref | ||
| end | ||
| Del_Vv_d = ω * imag_imped * (Iq_cnv_ref2 - Iq_cnv_ref) + real_imped * (Id_cnv_ref - Id_cnv_ref2) |
There was a problem hiding this comment.
I recommend here to be consistent with the signs rather than flipping signs inside the parenthesis.
u_d = Id_cnv_ref - Id_cnv_ref2
u_q = Iq_cnv_ref - Id_cnv_ref2
u = u_d + u_q * 1im
Z = R_vi + L_vi * ω
# u * Z = R_vi * u_d - L_vi * ω * u_q + 1im ( u_q * R_vi + u_d * L_vi)
Del_Vv_d = R_vi * u_d - L_vi * ω * u_q
Del_Vv_q = R_vi * u_q + L_vi * ω * u_d
It seems that the implementation is correct as Del_Vv_d has the signs flipped in the q-axis.
Pull Jd/psy4 update
|
@HaleyRoss and @rodrigomha is this in a good place to merge? |
rodrigomha
approved these changes
Jul 8, 2024
jd-lara
added a commit
that referenced
this pull request
Jul 8, 2024
* correct get_rate to get_rating (#381) * bump dependencies * Hr/add limiters (#376) * Add current limiters to inner_conrol_models * Fix limiter integration mistakes * Add saturation limiting logic * Add hybrid limiter control logic * Correct sign error hybrid limiter * Remove print * Change PowerSystems version * modify inner control gain * debug * fix mag limiter * change placement of kiv in hyblim * debug load * revert debug --------- Co-authored-by: Rodrigo Henríquez-Auba <[email protected]> * bump project toml * formatter * reuse multiple dispatch * change exponential names * update json exponential coefficients * revert IS check * change Union to real types * try catch for test 10 * add sim type * update printing * change to logs * update printing * add directly the LinearMatrix * revert try and catch --------- Co-authored-by: HaleyRoss <[email protected]> Co-authored-by: Rodrigo Henríquez-Auba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add control logic for output current limiters.