Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more CI to GW-CI #42

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Add more CI to GW-CI #42

merged 6 commits into from
Nov 8, 2024

Conversation

DavidNew-NOAA
Copy link
Contributor

This PR is a companion to #1365. It adds test reference blocks to the YAMLs for the JEDI-to-FV3 increment converters.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@CoryMartin-NOAA CoryMartin-NOAA merged commit 6d3a5bd into develop Nov 8, 2024
1 check failed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/gw-ci branch November 8, 2024 13:55
@danholdaway
Copy link
Collaborator

In jcb-algorithsm the if looks like:

{% if test_reference_filename is defined %}

whereas the changes here are using

{% if do_testing %}

Why not use the same logic that's in jcb-algorithms in jcb-gdas/algorithms?

@DavidNew-NOAA
Copy link
Contributor Author

DavidNew-NOAA commented Nov 12, 2024

jcb-algorithms PR #7 changed the logic in that repo as well. I used do_testing so I can set it in the JCB base yaml, which can be modified via theconfig.base in the GW, which in turn can be modified via the config YAMLs for the CI tests.

Before, test_reference_filename was only set in the JCB algorithm YAMLs for the jjob tests in GDASApp. If I put the same thing the primary JCB algorithm YAMLs in GDASApp, testing would always be turned on. I needed a way to turn it on and off. See the companion GDASApp PR #1365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants