-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more CI to GW-CI #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve.
This is probably not an ideal way to change things. You need to have do_testing in every single application of JCB whether it's true or false. Better would have been:
FYI the testing of jcb is working now so we shouldn't ignore failures. I suspect that if we tried to run GDASapp with this we'd see a lot of failures because of the need to add |
Before I fix things, what was wrong with using |
@danholdaway See my comment here NOAA-EMC/jcb-gdas#42 (comment) |
OK. Then I will apply the same to all the YAMLs in jcb-algo. |
This PR was merged a bit prematurely, I was hoping to have your eyes on it before that happened. |
No problem. Straightforward fix I think. And apologies that I did not review sooner. |
This PR is a companion to #1365. It makes inclusion of the testing blocks in the algorithm templates dependent on a
do_testing
parameter that will be set in the JCB base YAML.